Uploaded image for project: 'Ibexa IBX'
  1. Ibexa IBX
  2. IBX-5491

[migrations]: Adding a field without providing a name breaks content editing

    XMLWordPrintable

Details

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Medium Medium
    • Customer request
    • 4.4.1
    • Content
    • None
    • Yes

    Description

      Steps to reproduce:
      1. Create update migration for the folder Content Type:

      php bin/console ibexa:migrations:generate \
      --type=content_type \
      --mode=update --match-property=content_type_identifier \
      --value=folder
      

      2. Add the following to the end of the generated file:

      src/Migrations/Ibexa/migrations/xyz_content_type.yaml
              -   identifier: foo
                  type: ezboolean
                  position: 5
      

      3. Run migration:

      php bin/console ibexa:migrations:migrate --file=xyz_content_type.yaml
      

      4. Edit and publish some folder Content

      Result:
      JS error is thrown and Content is not saved:

      ibexa-admin-ui-content-edit-parts-js.js:6065 Uncaught TypeError: Cannot read properties of null (reading 'innerHTML')
          at EzBooleanValidator.validateInput (ibexa-admin-ui-content-edit-parts-js.js:6065:99)
          at EzBooleanValidator.validateField (ibexa-admin-ui-content-edit-parts-js.js:5067:53)
          at ibexa-admin-ui-content-edit-parts-js.js:5141:32
          at Array.forEach (<anonymous>)
          at EzBooleanValidator.isValid (ibexa-admin-ui-content-edit-parts-js.js:5139:31)
          at getValidationResults (ibexa-admin-ui-content-edit-parts-js.js:4646:29)
          at Array.map (<anonymous>)
          at isFormValid (ibexa-admin-ui-content-edit-parts-js.js:4704:40)
          at HTMLButtonElement.clickHandler (ibexa-admin-ui-content-edit-parts-js.js:4688:9)
          at HTMLButtonElement.trigger (ibexa-admin-ui-layout-js.js:62846:28)
      

      Expected:
      Running the update migration should already fail and indicate that a name is required for fields in update/create migrations as in:

              -   identifier: foo
                  type: ezboolean
                  position: 5
                  translations:
                      eng-GB:
                          name: 'Foo Name'
      

      Designs

        Attachments

          Activity

            People

              Unassigned Unassigned
              thorsten.reiter@ibexa.co Thorsten Reiter
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated: