Details
-
Bug
-
Resolution: Unresolved
-
Medium
-
4.5.6, 4.6.2
-
None
-
None
-
Ibexa Commerce, Ibexa Content, Ibexa Experience
-
Yes
Description
Call of $this->blockDefinitionFactory->getBlockDefinition('collection')
in map() method seems unneeed as $blockDefinition is passed as argument.
ibexa/fieldtype-page/src/lib/FieldType/Page/Block/Attribute/FormTypeMapper/LocationListFormTypeMapper.php
... /** * @param \Symfony\Component\Form\FormBuilderInterface $formBuilder * @param \Ibexa\Contracts\FieldTypePage\FieldType\Page\Block\Definition\BlockDefinition $blockDefinition * @param \Ibexa\Contracts\FieldTypePage\FieldType\Page\Block\Definition\BlockAttributeDefinition $blockAttributeDefinition * @param array $constraints * * @return \Symfony\Component\Form\FormBuilderInterface * * @throws \Exception */ public function map( FormBuilderInterface $formBuilder, BlockDefinition $blockDefinition, BlockAttributeDefinition $blockAttributeDefinition, array $constraints = [] ): FormBuilderInterface { $blockDefinition = $this->blockDefinitionFactory->getBlockDefinition('collection'); $locationListAttribute = $blockDefinition->getAttributes()['locationlist']; return $formBuilder->create( 'value', AttributeLocationListType::class, [ 'match' => $locationListAttribute->getOptions()['match'], 'constraints' => $constraints, ] ); } ..