Details
-
Improvement
-
Resolution: Fixed
-
Medium
-
4.0.1
-
None
Description
eZXMLInputType contains some weird legacy code, which should be partially removed:
if ( $inputHandler == "standard" ) { if ( file_exists( "kernel/classes/datatypes/ezxmltext/ezxmlinputhandler.php" ) ) { //include_once( "kernel/classes/datatypes/ezxmltext/ezxmlinputhandler.php" ); $impl = new eZXMLInputHandler(); } } elseif ( $inputHandler == "dhtml" ) { if ( $isMSIE and ( file_exists( "extension/xmleditor/" . $inputHandler . "/ezdhtmlinputhandler.php" ) ) and ( $disableExtension == false ) ) { include_once( "extension/xmleditor/" . $inputHandler . "/ezdhtmlinputhandler.php" ); $impl = new eZDHTMLInputHandler(); } else { if ( file_exists( "kernel/classes/datatypes/ezxmltext/ezxmlinputhandler.php" ) ) { //include_once( "kernel/classes/datatypes/ezxmltext/ezxmlinputhandler.php" ); $impl = new eZXMLInputHandler(); } } } else { eZDebug::writeError( "No XML editor available." ); } return $impl;
Hardcoded identifiers like "dhtml" and paths like extension/xmleditor/ in code like this is evil
Attachments
Issue Links
- relates to
-
EZP-12552 Remove some deprecated features
- Closed